Update pull request template with working links #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xibz
force-pushed
the
pull-request-template
branch
from
d85270d to
436becc
Compare
e-backmark-ericsson
requested changes
Aug 14, 2023
xibz
force-pushed
the
pull-request-template
branch
from
0dcb40f to
099c7e6
Compare
e-backmark-ericsson
approved these changes
Aug 15, 2023
Contributor
|
Almost there, but the commit doesn't seem to be signed. We have a requirement on that all commits merged in cdevents shall be signed. |
A couple links seems to be outdated which results in 404s. This commit addresses that by pointing to the CDEvents primer website with the appropriate sub-links. Co-authored-by: Emil Bäckmark <emil.backmark@ericsson.com> Signed-off-by: benjamin-j-powell <benjamin_j_powell@apple.com>
xibz
force-pushed
the
pull-request-template
branch
from
099c7e6 to
f824f64
Compare
Contributor
Author
|
@e-backmark-ericsson done! |
xibz
added a commit
to xibz/cdevents-spec
that referenced
this pull request
Oct 13, 2023
A couple links seems to be outdated which results in 404s. This commit addresses that by pointing to the CDEvents primer website with the appropriate sub-links. Signed-off-by: benjamin-j-powell <benjamin_j_powell@apple.com> Co-authored-by: benjamin-j-powell <benjamin_j_powell@apple.com> Co-authored-by: Emil Bäckmark <emil.backmark@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A couple links seems to be outdated which results in 404s. This commit addresses that by pointing to the CDEvents primer website with the appropriate sub-links.
Submitter Checklist
As the author of this PR, please check off the items in this checklist: