Skip to content

Define every url and viewUrl field as format uri #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afrittoli merged 2 commits into from
Dec 4, 2024
Merged

Define every url and viewUrl field as format uri #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4e8e1e
Define every `url` and `viewUrl` field as format `uri`
davidB Apr 7, 2024
cc5754a
! Rename every `url` field into `uri`
davidB Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cloudevents-binding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ description: >
CloudEvents Binding for CDEvents
---
-->
# CloudEvents Binding for CDEvents
# CloudEvents Binding for CDEvents <!-- omit in toc -->

## Abstract
## Abstract <!-- omit in toc -->

The CloudEvents Binding for CDEvents defines how CDEvents are mapped to CloudEvents headers and body.

## Table Of Contents
## Table Of Contents <!-- omit in toc -->

<!-- toc -->
- [CloudEvents Context](#cloudevents-context)
Expand Down Expand Up @@ -113,7 +113,7 @@ Content-Length: nnnn
"type": "taskRun",
"content": {
"task": "my-task",
"url": "/apis/tekton.dev/v1beta1/namespaces/default/taskruns/my-taskrun-123"
"uri": "/apis/tekton.dev/v1beta1/namespaces/default/taskruns/my-taskrun-123"
"pipelineRun": {
"id": "/somewherelse/pipelinerun-123",
"source": "/staging/jenkins/"
Expand Down
2 changes: 1 addition & 1 deletion conformance/environment_created.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"type": "environment",
"content": {
"name": "testEnv",
"url": "https://example.org/testEnv"
"uri": "https://example.org/testEnv"
}
}
}
2 changes: 1 addition & 1 deletion conformance/environment_modified.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"type": "environment",
"content": {
"name": "testEnv",
"url": "https://example.org/testEnv"
"uri": "https://example.org/testEnv"
}
}
}
2 changes: 1 addition & 1 deletion conformance/pipelinerun_finished.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"type": "pipelineRun",
"content": {
"pipelineName": "myPipeline",
"url": "https://www.example.com/mySubject123",
"uri": "https://www.example.com/mySubject123",
"outcome": "failure",
"errors": "Something went wrong\nWith some more details"
}
Expand Down
2 changes: 1 addition & 1 deletion conformance/pipelinerun_queued.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"type": "pipelineRun",
"content": {
"pipelineName": "myPipeline",
"url": "https://www.example.com/mySubject123"
"uri": "https://www.example.com/mySubject123"
}
}
}
2 changes: 1 addition & 1 deletion conformance/pipelinerun_started.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"type": "pipelineRun",
"content": {
"pipelineName": "myPipeline",
"url": "https://www.example.com/mySubject123"
"uri": "https://www.example.com/mySubject123"
}
}
}
2 changes: 1 addition & 1 deletion conformance/repository_created.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"content": {
"name": "TestRepo",
"owner": "TestOrg",
"url": "https://example.org/TestOrg/TestRepo",
"uri": "https://example.org/TestOrg/TestRepo",
"viewUrl": "https://example.org/view/TestOrg/TestRepo"
}
}
Expand Down
2 changes: 1 addition & 1 deletion conformance/repository_deleted.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"content": {
"name": "TestRepo",
"owner": "TestOrg",
"url": "https://example.org/TestOrg/TestRepo",
"uri": "https://example.org/TestOrg/TestRepo",
"viewUrl": "https://example.org/view/TestOrg/TestRepo"
}
}
Expand Down
2 changes: 1 addition & 1 deletion conformance/repository_modified.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"content": {
"name": "TestRepo",
"owner": "TestOrg",
"url": "https://example.org/TestOrg/TestRepo",
"uri": "https://example.org/TestOrg/TestRepo",
"viewUrl": "https://example.org/view/TestOrg/TestRepo"
}
}
Expand Down
2 changes: 1 addition & 1 deletion conformance/taskrun_finished.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"type": "taskRun",
"content": {
"taskName": "myTask",
"url": "https://www.example.com/mySubject123",
"uri": "https://www.example.com/mySubject123",
"pipelineRun": {
"id": "mySubject123"
},
Expand Down
2 changes: 1 addition & 1 deletion conformance/taskrun_started.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"type": "taskRun",
"content": {
"taskName": "myTask",
"url": "https://www.example.com/mySubject123",
"uri": "https://www.example.com/mySubject123",
"pipelineRun": {
"id": "mySubject123"
}
Expand Down
6 changes: 3 additions & 3 deletions links.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ systems to act accordingly based off the ending notation.
"type": "pipelineRun",
"content": {
"pipelineName": "myPipeline",
"url": "https://www.example.com/mySubject123"
"uri": "https://www.example.com/mySubject123"
}
}
}
Expand Down Expand Up @@ -221,7 +221,7 @@ further, we can allow for a path link between `pipelinerun.queued` to the
"type": "pipelineRun",
"content": {
"pipelineName": "myPipeline",
"url": "https://www.example.com/mySubject123"
"uri": "https://www.example.com/mySubject123"
}
}
}
Expand Down Expand Up @@ -433,7 +433,7 @@ sender generates this id.
"type": "pipelineRun",
"content": {
"pipelineName": "myPipeline",
"url": "https://www.example.com/mySubject123"
"uri": "https://www.example.com/mySubject123"
}
}
}
Expand Down
5 changes: 3 additions & 2 deletions schemas/environmentcreated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@
"name": {
"type": "string"
},
"url": {
"type": "string"
"uri": {
"type": "string",
"format": "uri"
}
},
"additionalProperties": false,
Expand Down
5 changes: 3 additions & 2 deletions schemas/environmentmodified.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@
"name": {
"type": "string"
},
"url": {
"type": "string"
"uri": {
"type": "string",
"format": "uri"
}
},
"additionalProperties": false,
Expand Down
5 changes: 3 additions & 2 deletions schemas/pipelinerunfinished.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@
"pipelineName": {
"type": "string"
},
"url": {
"type": "string"
"uri": {
"type": "string",
"format": "uri"
},
"outcome": {
"type": "string"
Expand Down
5 changes: 3 additions & 2 deletions schemas/pipelinerunqueued.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@
"pipelineName": {
"type": "string"
},
"url": {
"type": "string"
"uri": {
"type": "string",
"format": "uri"
}
},
"additionalProperties": false,
Expand Down
5 changes: 3 additions & 2 deletions schemas/pipelinerunstarted.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@
"pipelineName": {
"type": "string"
},
"url": {
"type": "string"
"uri": {
"type": "string",
"format": "uri"
}
},
"additionalProperties": false,
Expand Down
7 changes: 4 additions & 3 deletions schemas/repositorycreated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,13 @@
"owner": {
"type": "string"
},
"url": {
"uri": {
"type": "string",
"minLength": 1
"format": "uri"
},
"viewUrl": {
"type": "string"
"type": "string",
"format": "uri"
}
},
"additionalProperties": false,
Expand Down
8 changes: 5 additions & 3 deletions schemas/repositorydeleted.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,13 @@
"owner": {
"type": "string"
},
"url": {
"type": "string"
"uri": {
"type": "string",
"format": "uri"
},
"viewUrl": {
"type": "string"
"type": "string",
"format": "uri"
}
},
"additionalProperties": false,
Expand Down
8 changes: 5 additions & 3 deletions schemas/repositorymodified.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,13 @@
"owner": {
"type": "string"
},
"url": {
"type": "string"
"uri": {
"type": "string",
"format": "uri"
},
"viewUrl": {
"type": "string"
"type": "string",
"format": "uri"
}
},
"additionalProperties": false,
Expand Down
5 changes: 3 additions & 2 deletions schemas/taskrunfinished.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@
"taskName": {
"type": "string"
},
"url": {
"type": "string"
"uri": {
"type": "string",
"format": "uri"
},
"pipelineRun": {
"properties": {
Expand Down
5 changes: 3 additions & 2 deletions schemas/taskrunstarted.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@
"taskName": {
"type": "string"
},
"url": {
"type": "string"
"uri": {
"type": "string",
"format": "uri"
},
"pipelineRun": {
"properties": {
Expand Down
2 changes: 1 addition & 1 deletion schemas/testsuiterunqueued.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
"name": {
"type": "string"
},
"url": {
"uri": {
"type": "string",
"format": "uri"
}
Expand Down
4 changes: 2 additions & 2 deletions spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ defined in the [vocabulary](#vocabulary):
```json
"content" : {
"task": "my-task",
"url": "/apis/tekton.dev/v1beta1/namespaces/default/taskruns/my-taskrun-123"
"uri": "/apis/tekton.dev/v1beta1/namespaces/default/taskruns/my-taskrun-123"
}
```

Expand Down Expand Up @@ -468,7 +468,7 @@ The following example shows `context` and `subject` together, rendered as JSON.
"type": "taskRun",
"content": {
"task": "my-task",
"url": "/apis/tekton.dev/v1beta1/namespaces/default/taskruns/my-taskrun-123",
"uri": "/apis/tekton.dev/v1beta1/namespaces/default/taskruns/my-taskrun-123",
"pipelineRun": {
"id": "my-distributed-pipelinerun",
"source": "/tenant1/tekton/"
Expand Down