Changes snake cased fields to camel casing #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
tied to #205 |
Contributor
Author
|
fixes #204 |
xibz
added
the
breaking change
Member
|
@xibz do you consider this a bug that we should fix in a 0.4.1 or shall we wait for 0.5.0? |
Contributor
Author
|
@afrittoli my thinking was we could fix it now since the sdks haven't been updated yet |
Member
OK, it sounds good - however, to fix this on the 0.4 version, you'll need a new PR to the Since this PR changes all event definitions, it will have to include an update to all events (and corresponding examples) patch versions. |
Since all references to the link schemas have been updated, we need
to bump all event versions too.
This as usual is automated:
ls examples | while read aa; do sp="$(echo ${aa%.*} | tr "_" ".")"; ./tools/event-version.sh -u $sp -s; done
Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
Signed-off-by: xibz <impactbchang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves consistency in our spec and examples by having all keys be camel cased.
This made 4 changes:
chain_id -> chainId
context_id -> contextId
link_kind -> linkKind
link_type -> linkType