chore!: remove subject.type #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEE cdevents#189 Signed-off-by: David Bernard <david.bernard.31@gmail.com>
SEE cdevents#189 Signed-off-by: David Bernard <david.bernard.31@gmail.com>
Signed-off-by: David Bernard <david.bernard.31@gmail.com>
davidB
changed the title
afrittoli
approved these changes
Aug 26, 2025
Member
afrittoli
left a comment
afrittoli
left a comment
There was a problem hiding this comment.
Thanks! This will require some work on the SDKs, so it's good to have it in v0.5
Contributor
Author
|
@afrittoli If it's ok, then you can merge it (I can't and I don't want/need this power ;-) ) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
SEE #189
Remove the field
subject.typefrom:The types with camel case (e.g. pipelineRun, testCaseRun) were not changed in the documentation, but should no longer be present in the JSON schema & samples.
The changes are split into commit, to ease the review (if you want). It was a manual operation, I ran validate.sh locally, the only reported error is due to an other issue fixed into an other PR #261
Submitter Checklist
As the author of this PR, please check off the items in this checklist: