Skip to content

Conversation

@xibz
Copy link
Contributor

@xibz xibz commented Oct 9, 2025

This commit removes additional dashes, e.g., test-case-run. This makes tools have a harder time matching events due to the subjects being non-dashed words.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

This commit removes additional dashes, e.g., test-case-run. This makes
tools have a harder time matching events due to the subjects being
non-dashed words.

Signed-off-by: xibz <bjp@apple.com>
@xibz xibz requested a review from davidB October 9, 2025 14:38
@xibz xibz requested a review from a team as a code owner October 9, 2025 14:39
@afrittoli
Copy link
Member

@xibz
Copy link
Contributor Author

xibz commented Nov 4, 2025

@afrittoli - That script looks to just copy and does not do anything with the $id value from what I can see. It does an awk, but I believe that should still work.

We can merge this and test later unless there are tests for this already. Just need your approval to merge.

@afrittoli
Copy link
Member

@afrittoli - That script looks to just copy and does not do anything with the $id value from what I can see. It does an awk, but I believe that should still work.

We can merge this and test later unless there are tests for this already. Just need your approval to merge.

Well, that script is used to publish the schemas, and it does rely on the id https://github.com/cdevents/cdevents.dev/blob/ce1cf8d1d9dda46c25a79502bcf08de389509349/scripts/build-static.sh#L25 - I'll try to test it today on your PR and propose a fix is needed

@afrittoli
Copy link
Member

afrittoli commented Nov 6, 2025

@xibz the signature on your commit seems invalid or missing - I'll override for this PR

@afrittoli afrittoli merged commit 3629760 into cdevents:main Nov 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants