Fixing #251 support for circular references in lists#259
Merged
cdgriffith merged 2 commits intocdgriffith:developfrom Jun 12, 2024
Merged
Fixing #251 support for circular references in lists#259cdgriffith merged 2 commits intocdgriffith:developfrom
cdgriffith merged 2 commits intocdgriffith:developfrom
Conversation
c78844d to
1e26885
Compare
Owner
|
I have no idea how this fell off my radar, I apologize! Thank you so much for looking into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I read #251 and think that using
isoperator to identify objects may fix the problemidbrings.For now, you can:
BoxListwith a list with circular referencesNote this:
This is because:
iterablepassing to__init__.ais not the same asbanymore, I think users appendingbtoais not intended to appendatoa.