Handling real multi line entries.#78
Merged
cdimascio merged 2 commits intocdimascio:masterfrom Dec 15, 2024
Merged
Conversation
cdimascio
reviewed
Oct 25, 2024
| for (final var line : lines) { | ||
| addNewEntry(entries, line.trim()); | ||
| } | ||
| if (currentEntry.equals("") && (isWhiteSpace.test(line) || isComment.test(line) || isBlank(line))) |
Owner
There was a problem hiding this comment.
if we have a multi line string that contains comments or whitespace
e.g.
MULTI_LINE="hello
there
# not a comment
how's it going
"
will this ignore two lines, "# not a comment" and the blank link?
Owner
There was a problem hiding this comment.
verified that this behaves corrextly
cdimascio
reviewed
Oct 25, 2024
Owner
cdimascio
left a comment
cdimascio
left a comment
There was a problem hiding this comment.
thanks you for putting this together
|
Greetings. Can you tell me when these changes will be merged? |
cdimascio
approved these changes
Dec 15, 2024
Owner
Changes are merged. Best! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #77. A new implementation for handling multiline entries that span across several lines (not only with \n). The code is now considering the quotes to start and end a multiline entry.