fix: request schema preprocessor and multipart middleware custom formats#452
Merged
cdimascio merged 3 commits intocdimascio:masterfrom Nov 9, 2020
Merged
Conversation
72253ce to
e60315e
Compare
Owner
|
@LEI thanks. this is definitely the right idea. i ended building upon you change to extract the ajv options into common handler class, so that future modifications can be made more easily across the various internal middlewares. |
Owner
|
@all-contributors add @LEI for code |
Contributor
|
I've put up a pull request to add @LEI! 🎉 |
ex1st
pushed a commit
to ex1st/express-openapi-validator
that referenced
this pull request
Dec 9, 2020
…ats (cdimascio#452) * fix: request schema preprocessor unknown format error * fix: multipart middleware ajv options formats and types * common ajv options handler Co-authored-by: Carmine DiMascio <cdimascio@gmail.com>
cdimascio
added a commit
that referenced
this pull request
Mar 2, 2025
…ats (#452) * fix: request schema preprocessor unknown format error * fix: multipart middleware ajv options formats and types * common ajv options handler Co-authored-by: Carmine DiMascio <cdimascio@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure about this, but the
formatsseems required for the request schema preprocessor and the multipart middleware ajv instances.Moreover, I could not catch the RequestSchemaPreprocessor error (unhandled rejection):
Finally, I updated the MultipartOpts type in the second commit to accept the ajv options as a property (
ajvOpts).