Features/support serialization in array items#666
Closed
markablov wants to merge 2 commits intocdimascio:masterfrom
Closed
Features/support serialization in array items#666markablov wants to merge 2 commits intocdimascio:masterfrom
markablov wants to merge 2 commits intocdimascio:masterfrom
Conversation
|
This feature is the major ⚠ blocker for the migration from previous semver major to the current one 🤌 |
cdimascio
approved these changes
Jun 2, 2024
cdimascio
approved these changes
Jun 2, 2024
Owner
cdimascio
left a comment
cdimascio
left a comment
There was a problem hiding this comment.
some of these changes have been made. created another PR that includes the tests, but excludes the array fix, as it is already present in master
Owner
|
closing - note that array serialization is already on master, however i added the tests that @markablov created in this PR here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added test that shows the issue - serialization does not apply to schemas for array items.