---Location b--- Snapper rework #48
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phylums displayed are base on if the drops are needed and the phylum reachable (always reachable out of run) also displays a phylum if tracked or in the current zone May want to remember this commit: I plan to change part of the code into a "switch" however, if it doesn't clutter too much, may want to display to the user where a phylum can be found? The current code would be better for that...
have it be easier to look for a phylum in the code
tried to add options to tile (ergonomically), but failed
Collaborator
Author
|
self-reminder: the changes in misc items.ash and red nosed snapper.ash will need to be compliant to the Minimize "new standards" |
Collaborator
Author
|
included in "minimize" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yep, totally a branch that touches red-nosed snapper, and only red-nosed snapper, without ever going on a rampant series of edits on another section <.< ... ... ...
...
...
...
...
Ok...
Ya got me...
Rampant series of edits... <.<
Complete rework of the snapper tile. Now shows phylums based on your assumed needs, and shows the phylum tracked and in current location.
Adds a warning if you're bringing the snapper and its phylum tracking is undoing a banish.
Rework of the appearance_rates_adjusted function (used in the location bar and to calculate the average turns a task will take, like bounties), which now relies more confidently on mafia's data.
(Somewhat smaller) Rework of the location bar:
Having copies of a monster, form olfaction or olfaction-likes, stops monsters from being shown as simply "banished" (btw, plz report more locations in which banishes are impossible).
Also stops only displaying a "?" for meat and drop chance when underwater.
Also also, fixes what caused the partial blurring of the left side of the base drop % of monsters' items in the location bar popup.