Skip to content

Comments

Add support for cedar-policy-formatter#180

Merged
shaobo-he-aws merged 3 commits intocedar-policy:mainfrom
felixzheng98:main
Jul 18, 2024
Merged

Add support for cedar-policy-formatter#180
shaobo-he-aws merged 3 commits intocedar-policy:mainfrom
felixzheng98:main

Conversation

@felixzheng98
Copy link
Contributor

Issue #, if available:

Description of changes:

This PR adds support for cedar-policy-formatter.

  • Add dependency to cedar-policy-formatter on the FFI side
  • Add jni for cedar_policy_formatter::policies_str_to_pretty
  • Create PolicyFormatter on Java side

Signed-off-by: Felix Zheng <felix.zheng@mongodb.com>
Signed-off-by: Felix Zheng <felix.zheng@mongodb.com>
Signed-off-by: Felix Zheng <felix.zheng@mongodb.com>
Copy link
Contributor

@shaobo-he-aws shaobo-he-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nits.

@felixzheng98
Copy link
Contributor Author

Please merge this for me when convenient as I don't have permissions to merge. Thank you!

@shaobo-he-aws shaobo-he-aws merged commit de0c8b6 into cedar-policy:main Jul 18, 2024
@shaobo-he-aws
Copy link
Contributor

Please merge this for me when convenient as I don't have permissions to merge. Thank you!

Merged. Thank you for your contribution.

@khieta khieta mentioned this pull request Jul 23, 2024
2 tasks
shaobo-he-aws pushed a commit that referenced this pull request Aug 19, 2024
Signed-off-by: Felix Zheng <felix.zheng@mongodb.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
khieta pushed a commit that referenced this pull request Aug 23, 2024
Signed-off-by: Felix Zheng <felix.zheng@mongodb.com>
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Co-authored-by: Felix Zheng <37223155+felixzheng98@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants