generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 30
Exposes policy effect for static policies and templates #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
30d0106
exposes policy effect for static policies and template
muditchaudhary 477c56d
adds unit tests for get policy effect
muditchaudhary 0dbed4a
removes enclosing quotes from policy effect
muditchaudhary d0967d3
adds Effect enum; refactors code and tests to use Effect enum
muditchaudhary b6fd4d0
simplifies policy effect to string conversion in CedarJavaFFI
muditchaudhary File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package com.cedarpolicy.model; | ||
|
|
||
| /** | ||
| * Represents the effect of a Cedar policy. | ||
| */ | ||
| public enum Effect { | ||
| PERMIT, | ||
| FORBID; | ||
|
|
||
| /** | ||
| * Converts a string to an Effect enum value, case-insensitive. | ||
| * | ||
| * @param effectString the string value to convert | ||
| * @return the corresponding Effect enum value | ||
| * @throws NullPointerException if the effectString is null | ||
| * @throws IllegalArgumentException if the effectString doesn't match any Effect in {permit, forbid} | ||
| */ | ||
| public static Effect fromString(String effectString) { | ||
|
|
||
| if (effectString == null) { | ||
| throw new NullPointerException(); | ||
| } | ||
|
|
||
| switch (effectString.toLowerCase()) { | ||
| case "permit": | ||
| return PERMIT; | ||
| case "forbid": | ||
| return FORBID; | ||
| default: | ||
| throw new IllegalArgumentException("Invalid Effect: " + effectString + ". Expected 'permit' or 'forbid'"); | ||
| } | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.