Adds functionality to parse Entity from JSON#292
Merged
muditchaudhary merged 17 commits intocedar-policy:mainfrom Feb 12, 2025
Merged
Adds functionality to parse Entity from JSON#292muditchaudhary merged 17 commits intocedar-policy:mainfrom
muditchaudhary merged 17 commits intocedar-policy:mainfrom
Conversation
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
adpaco-aws
approved these changes
Feb 11, 2025
CedarJava/src/main/java/com/cedarpolicy/model/entity/Entity.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
cdisselkoen
approved these changes
Feb 12, 2025
Contributor
cdisselkoen
left a comment
There was a problem hiding this comment.
Looks good. I didn't look at the tests in detail but I trust they are correct. I think we already test this functionality through the corpus tests anyway?
jtbrain
pushed a commit
to jtbrain/cedar-java
that referenced
this pull request
Feb 18, 2025
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EntityDeserializerfor converting JSON strings intoEntityobjects.CedarJsonvisibility to allow its use in a different package or module.Entityclass:Entity.parse(String jsonString): Loads anEntityfrom a JSON string.Entity.parse(Path filePath): Loads anEntityfrom a JSON file.Entity.parse()methods.