Adds DateTime Extension Support#328
Merged
muditchaudhary merged 7 commits intocedar-policy:mainfrom Aug 15, 2025
Merged
Conversation
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
muditchaudhary
commented
Aug 12, 2025
| /** Convert DateTime to Cedar expr that can be used in a Cedar policy. */ | ||
| @Override | ||
| public String toCedarExpr() { | ||
| return "datetime(\"" + dateTime + "\")"; |
Contributor
There was a problem hiding this comment.
Worried about this being valid, but should be fine since dateTime is validated on construction, cannot be mutated externally since it's private and it's set once.
Contributor
Author
There was a problem hiding this comment.
Yeah. It's final and only assigned after validation so should be ok. This is what we do for IpAddress as well
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds DateTime Extension Support (RFC 80)
Changes
Implements new
com.cedarpolicy.value.DateTimeclassDateTimevalue inStringrepresentationIntegrates
DateTimesupport in serialization layerValueSerializerto handleDateTimeserializationDateTimedeserialization support inValueDeserializerTesting
DateTimevalidation, serialization, and edge casesDateTimefunctionalityUpdates CHANGELOG
Example Usage