Reduce implementation dependencies#81
Merged
cdisselkoen merged 1 commit intocedar-policy:mainfrom Feb 9, 2024
Merged
Conversation
- Removed unused Apache Commons Text - Removed Google Guava - Replaced Guava ImmutableList with Collection.unmodifiableList() - Changed FindBugs annotations library to compileOnly - Changed Log4j 2 to testImplementation
cdisselkoen
approved these changes
Feb 7, 2024
khieta
approved these changes
Feb 9, 2024
Contributor
|
Thanks for this PR! |
Contributor
Author
Thanks for reviewing and merging! |
This was referenced Feb 12, 2024
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This pull request reduces the number and scope of dependencies required for the
cedar-javalibrary.Changes include the following:
Apache Commons Text did not have any direct references in Java classes. Log4j 2 is only necessary for test classes, so it should be declared as a test implementation dependency, allowing runtime integrations to provide an SLF4J implementation as needed.
FindBugs provides annotations to suppress FindBugs warnings, but these annotations are not necessary for runtime operation, as Java Virtual Machines ignore missing annotation classes when loading.
Usage of Google Guava was limited to
ImmutableListandImmutableSetin two classes. These references can be replaced with standard Java wrappersCollections.unmodifiableList()andCollections.unmodifiableSet(), avoiding the need for Guava entirely.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.