fix: cleanup before new connection#132
Open
fedor wants to merge 1 commit into
Open
Conversation
Enables reuse of fivebeans handler. Since I want to reuse the same fivebeans client object for reconnection, I call `FiveBeansClient.prototype.connect()` more than once. As a result, a callback for an old socket may exist in `self.handlers` after a new socket is created. In this case, the first command with the new socket will stuck, because its callback will not be called (a callback for the old socket will be called instead).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ceejbot,
Enables reuse of fivebeans handler.
Since I want to reuse the same fivebeans client object for reconnection, I call
FiveBeansClient.prototype.connect()more than once.As a result, a callback for an old socket may exist in
self.handlersafter a new socket is created. In this case, the first command with the new socket will stuck, because its callback will not be called (a callback for the old socket will be called instead).