This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Expose the factory methods of MonitoredResource.#1250
Merged
songy23 merged 3 commits intocensus-instrumentation:masterfrom Jun 12, 2018
Merged
Expose the factory methods of MonitoredResource.#1250songy23 merged 3 commits intocensus-instrumentation:masterfrom
songy23 merged 3 commits intocensus-instrumentation:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1250 +/- ##
============================================
+ Coverage 82.06% 82.48% +0.42%
- Complexity 1241 1244 +3
============================================
Files 193 193
Lines 6044 6047 +3
Branches 560 560
============================================
+ Hits 4960 4988 +28
+ Misses 935 909 -26
- Partials 149 150 +1
Continue to review full report at Codecov.
|
Contributor
|
LGTM |
sebright2
reviewed
Jun 12, 2018
| * @return an {@code AwsEc2InstanceMonitoredResource}. | ||
| * @since 0.15 | ||
| */ | ||
| public static AwsEc2InstanceMonitoredResource create() { |
Contributor
There was a problem hiding this comment.
Could we continue hiding the no-arg factory methods, to reduce the size of the API? I also think that the no-arg methods could be confusing, because users might expect the factory methods in AutoValue classes to be deterministic, but these depend on the environment.
Contributor
Author
There was a problem hiding this comment.
Make sense to me, done.
sebright2
approved these changes
Jun 12, 2018
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make the unit tests of other libraries that depend on
monitored-resource-utilseasier to write.