Monitored Resource: replace gke_container with k8s_container in SD exporter#1467
Monitored Resource: replace gke_container with k8s_container in SD exporter#1467mayurkale22 merged 3 commits intocensus-instrumentation:masterfrom mayurkale22:k8s_container
Conversation
songy23
left a comment
There was a problem hiding this comment.
LGTM. Will this be a breaking change for users that already use "gke_container" resources?
|
Yes, this is breaking change for existing user. SD also mentioned same in their release doc: https://cloud.google.com/monitoring/kubernetes-engine/migration#incompatible |
Please add an entry to CHANGELOG.md and point to the SD document. |
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
============================================
+ Coverage 82.39% 82.41% +0.02%
Complexity 1542 1542
============================================
Files 235 235
Lines 7232 7229 -3
Branches 689 689
============================================
- Hits 5959 5958 -1
+ Misses 1060 1059 -1
+ Partials 213 212 -1
Continue to review full report at Codecov.
|
…porter
Fixes #1445