Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Monitored Resource: replace gke_container with k8s_container in SD exporter#1467

Merged
mayurkale22 merged 3 commits intocensus-instrumentation:masterfrom
mayurkale22:k8s_container
Sep 24, 2018
Merged

Monitored Resource: replace gke_container with k8s_container in SD exporter#1467
mayurkale22 merged 3 commits intocensus-instrumentation:masterfrom
mayurkale22:k8s_container

Conversation

@mayurkale22
Copy link
Copy Markdown
Member

…porter

Fixes #1445

Copy link
Copy Markdown
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will this be a breaking change for users that already use "gke_container" resources?

@mayurkale22
Copy link
Copy Markdown
Member Author

Yes, this is breaking change for existing user. SD also mentioned same in their release doc: https://cloud.google.com/monitoring/kubernetes-engine/migration#incompatible

@songy23
Copy link
Copy Markdown
Contributor

songy23 commented Sep 21, 2018

Yes, this is breaking change for existing user. SD also mentioned same in their release doc: https://cloud.google.com/monitoring/kubernetes-engine/migration#incompatible

Please add an entry to CHANGELOG.md and point to the SD document.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 21, 2018

Codecov Report

Merging #1467 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1467      +/-   ##
============================================
+ Coverage     82.39%   82.41%   +0.02%     
  Complexity     1542     1542              
============================================
  Files           235      235              
  Lines          7232     7229       -3     
  Branches        689      689              
============================================
- Hits           5959     5958       -1     
+ Misses         1060     1059       -1     
+ Partials        213      212       -1
Impacted Files Coverage Δ Complexity Δ
...rter/stats/stackdriver/StackdriverExportUtils.java 83% <0%> (+0.4%) 31 <0> (ø) ⬇️
...race/stackdriver/StackdriverV2ExporterHandler.java 89.44% <100%> (-0.1%) 40 <0> (ø)
...census/implcore/trace/export/SpanExporterImpl.java 93.15% <0%> (+1.36%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c988a2...64a20ce. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants