This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Add Resource API#193
Merged
mayurkale22 merged 6 commits intocensus-instrumentation:masterfrom Nov 27, 2018
Merged
Conversation
songy23
approved these changes
Nov 19, 2018
mayurkale22
force-pushed
the
resourceAPI
branch
from
01e05d2 to
0577e51
Compare
Contributor
|
Please wait for Osvaldo`s review |
OsvaldoRosado
approved these changes
Nov 20, 2018
isaikevych
reviewed
Nov 20, 2018
| * <p>OC_RESOURCE_TYPE: A string that describes the type of the resource | ||
| * prefixed by a domain namespace, e.g. “kubernetes.io/container”. | ||
| */ | ||
| private static parseResourceType(rawEnvType: string): string { |
Contributor
There was a problem hiding this comment.
Could you please move private methods to top for more readability?
isaikevych
suggested changes
Nov 20, 2018
Contributor
isaikevych
left a comment
isaikevych
left a comment
There was a problem hiding this comment.
Please add documentation
isaikevych
reviewed
Nov 20, 2018
| * @returns {Resource} | ||
| */ | ||
| static createFromEnvironmentVariables(): Resource { | ||
| return new Resource(Resource.ENV_TYPE, Resource.ENV_LABEL_MAP); |
Contributor
There was a problem hiding this comment.
Why we need this? can we move it to constructor?
isaikevych
suggested changes
Nov 21, 2018
This was referenced Nov 21, 2018
mayurkale22
force-pushed
the
resourceAPI
branch
from
0577e51 to
3af6fdd
Compare
isaikevych
suggested changes
Nov 21, 2018
isaikevych
suggested changes
Nov 22, 2018
isaikevych
suggested changes
Nov 22, 2018
isaikevych
suggested changes
Nov 26, 2018
mayurkale22
force-pushed
the
resourceAPI
branch
from
c24d1f7 to
f3796a2
Compare
isaikevych
suggested changes
Nov 26, 2018
|
|
||
| import * as assert from 'assert'; | ||
|
|
||
| process.env.OC_RESOURCE_TYPE = 'k8s.io/container'; |
Contributor
There was a problem hiding this comment.
My guess that its necessary just for first describe, if so - please move to place of usage
mayurkale22
force-pushed
the
resourceAPI
branch
from
ee5c1b1 to
46df0d4
Compare
Member
Author
|
@isaikevych Thank you for the reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.