Metrics: use number for timestamp instead of interface#196
Metrics: use number for timestamp instead of interface#196mayurkale22 wants to merge 1 commit intocensus-instrumentation:masterfrom
number for timestamp instead of interface#196Conversation
bogdandrutu
left a comment
There was a problem hiding this comment.
And what is the unit?
|
Are you asking about unit tests or unit type in MetricDescriptor? |
|
Timestamp as a number should have a unit "us" or "ns" from the epoch. I am a bit lost in this PR logic. |
|
I was thinking to use |
|
https://www.geeksforgeeks.org/javascript-date-now/ so it seems that the timestamp you are proposing is millis since epoch. Do we have a way to get better timestamps (ns or us granularity)? |
@mayurkale22 I dont know what are you going to achieve by this changes but anyway |
|
As discussed, will use process.hrtime() to get timstamp in ns or us granularity. Closing this PR. |
No description provided.