This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Remove mocha type reference in @opencensus/core release code#254
Merged
mayurkale22 merged 5 commits intomasterfrom Jan 8, 2019
Merged
Remove mocha type reference in @opencensus/core release code#254mayurkale22 merged 5 commits intomasterfrom
@opencensus/core release code#254mayurkale22 merged 5 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 94.61% 94.61%
=======================================
Files 101 101
Lines 7312 7312
Branches 690 690
=======================================
Hits 6918 6918
Misses 394 394Continue to review full report at Codecov.
|
…census-node into remove-dts-mocha-ref
Contributor
Author
|
This will enable use of Jasmine for unit tests in the |
mayurkale22
approved these changes
Jan 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated code in
build/src/trace/model/tracer.d.tsandbuild/src/trace/model/types.d.tsincludes a line/// <reference types="mocha" />. I believe that's because TypeScript sees that theNodeJS.EventEmittertype is not defined in the file and so it pulls in the included global types, including the Mocha types. That means that when@opencensus/coreis imported into another TypeScript NPM module, it needs to bring in the@types/mochapackage in order to compile.This fixes that by separating out the test and release compilation steps and having two separate tsconfig files with different
typesdefinitions. As a side benefit, this also means thatnpm run preparewill fail if any code in thesrcfolder accidentally references any Mocha types.