This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Metrics: Fix DistributionValue buckets properties#258
Merged
mayurkale22 merged 2 commits intocensus-instrumentation:masterfrom Jan 2, 2019
Merged
Metrics: Fix DistributionValue buckets properties#258mayurkale22 merged 2 commits intocensus-instrumentation:masterfrom
mayurkale22 merged 2 commits intocensus-instrumentation:masterfrom
Conversation
mayurkale22
requested review from
isaikevych,
justindsmith and
songy23
and removed request for
isaikevych
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
==========================================
+ Coverage 94.61% 94.61% +<.01%
==========================================
Files 101 101
Lines 7311 7312 +1
Branches 690 690
==========================================
+ Hits 6917 6918 +1
Misses 394 394
Continue to review full report at Codecov.
|
songy23
approved these changes
Jan 2, 2019
As per metrics.proto, we omit exemplar field when the distribution does not have a histogram.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DistributionValue -> Bucket has two properties
countandexemplarin the metrics data model. This PR will honor these properties and assign values as per proto definition.Also, Make exemplar optional. As per metrics.proto, we omit exemplar field when the distribution does not have a histogram.