Simplify Logger interface, remove silly, make level optional#271
Simplify Logger interface, remove silly, make level optional#271mayurkale22 merged 3 commits intomasterfrom
Conversation
mayurkale22
left a comment
There was a problem hiding this comment.
Can you please update CHANGELOG with breaking change comment?
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
=========================================
+ Coverage 94.8% 94.8% +<.01%
=========================================
Files 110 110
Lines 7779 7764 -15
Branches 713 713
=========================================
- Hits 7375 7361 -14
+ Misses 404 403 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
=========================================
+ Coverage 94.8% 94.8% +<.01%
=========================================
Files 110 110
Lines 7779 7764 -15
Branches 713 713
=========================================
- Hits 7375 7361 -14
+ Misses 404 403 -1
Continue to review full report at Codecov.
|
|
@mayurkale22 I added a note to the changlog, could you take another look and merge if all is good? |
By removing
sillyand making thelevelattribute optional (and defaulted todebug) then theconsoleinterface itself will implementLogger. See this TS playgroundThis will be useful for
opencensus-webwhere a major goal is small code size for web clients, so being able to just useconsoleitself as a logger cuts down on code size.This does seem like a relatively minor breaking change though.