This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Nit: Export for tests and Singleton instance for BaseMetricProducerMa…#277
Merged
mayurkale22 merged 1 commit intocensus-instrumentation:masterfrom Jan 12, 2019
Merged
Conversation
mayurkale22
requested review from
draffensperger and
justindsmith
and removed request for
draffensperger
mayurkale22
commented
Jan 11, 2019
| } | ||
| } | ||
|
|
||
| export const metricProducerManagerInstance = new BaseMetricProducerManager(); |
Member
Author
There was a problem hiding this comment.
This will fix compiler error: error TS4025: Exported variable 'metricProducerManagerInstance' has or is using private name 'BaseMetricProducerManager'.
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
- Coverage 94.8% 94.78% -0.03%
==========================================
Files 110 110
Lines 7764 7764
Branches 713 714 +1
==========================================
- Hits 7361 7359 -2
- Misses 403 405 +2
Continue to review full report at Codecov.
|
draffensperger
approved these changes
Jan 11, 2019
justindsmith
approved these changes
Jan 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nager