This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Exporter/Stackdriver: Add common utils#321
Merged
mayurkale22 merged 1 commit intocensus-instrumentation:masterfrom Jan 31, 2019
Merged
Exporter/Stackdriver: Add common utils#321mayurkale22 merged 1 commit intocensus-instrumentation:masterfrom
mayurkale22 merged 1 commit intocensus-instrumentation:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 94.96% 94.97% +<.01%
==========================================
Files 118 119 +1
Lines 8170 8172 +2
Branches 732 732
==========================================
+ Hits 7759 7761 +2
Misses 411 411
Continue to review full report at Codecov.
|
draffensperger
approved these changes
Jan 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains common utils which is shared between stats and trace exporter especially to get default resources and its SD specific mappings. Also, removed some unused imports (I am planning to enforce
"noUnusedLocals": truevery soon on SD package) andAWS_REGION_VALUE_PREFIXconstant moved in exporter as this prefix is only important to SD.This PR is foundation for issuse #39.