Add message sizes to addMessageEvent function#344
Conversation
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 95.17% 95.14% -0.03%
==========================================
Files 122 122
Lines 8472 8474 +2
Branches 750 750
==========================================
Hits 8063 8063
- Misses 409 411 +2
Continue to review full report at Codecov.
|
mayurkale22
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this. We need to export these fields in the Stackdriver exporter (https://github.com/census-instrumentation/opencensus-node/blob/master/packages/opencensus-exporter-stackdriver/src/stackdriver-cloudtrace-utils.ts#L84), might be in new PR.
odeke-em
left a comment
There was a problem hiding this comment.
Cool, thank you @draffensperger for the follow-up and for adding them here too!
|
Yes, sure, I can add the exporter logic in a new PR. Probably need it for Stackdriver and agent. |
Message size parameters were added in #323 and this now adds them to the
addMessageEventfunction on span as optional parameters.This also adds a comment to the
idfield of theMessageEventinterface to explain that it is a hexadecimal string that should increment as new messages are sent.cc/ @odeke-em