This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Don't return transport along with SD stats exporter#605
Merged
c24t merged 1 commit intocensus-instrumentation:masterfrom Apr 9, 2019
Merged
Conversation
songy23
approved these changes
Apr 8, 2019
reyang
approved these changes
Apr 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts a change to
new_stats_exporterfrom #593 so that the method returns the exporter only, and not thePeriodicTaskthat it now starts on exporter creation. We need to merge this before releasing0.4.0(#604).Users generally won't need access to the task, but we may still want to return it here. In any case this is a breaking change, and if we consider
new_stats_exporterto be part of the stats API we shouldn't make this change in the stackdriver exporter until we're ready to do the same for prometheus.