Username support #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has already been merged into the original repo at netskin/ceph-ruby, see netskin/ceph-ruby#1
|
I've also got a pull request open #2 which also adds username support as well as cluster name support. It would be good to see these pull requests merged - username support in particular is needed to make this Gem useful outside of small test clusters. |
|
The problem with this PR is that it breaks backwards compatibility with ruby code. m1ari's PR requires librados2 as opposed to librados, however it doesn't alter the api, which is preferable imho. |
Author
|
Hey there, thanks for the feedback, missed it somehow. I changed the PR to not change the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has already been merged into the original repo at
netskin/ceph-ruby, see netskin/ceph-ruby#1