Open links in default browser #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Need to update ceramic to confirm which solution to use, sometime soon |
Contributor
Author
|
Pushing to master should use the newer solution since Electron is updated there, note to self |
For latest electron
jeremyfa
force-pushed
the
master
branch
12 times, most recently
from
43f9ee1 to
aeb18ef
Compare
Member
|
Merging that, let's see how it goes thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, opening links in a web build creates new electron windows instead of using the default browser. This opens them in the browser.
The solution is deprecated in Electron 22 and requires new API that isn't available on the current version of Electron, so it'll have to be changed or ifdef'd eventually.
Not familiar with js, let me know any feedback.