Skip to content

Conversation

@Jarrio
Copy link
Contributor

@Jarrio Jarrio commented Apr 17, 2025

No description provided.

@jeremyfa
Copy link
Member

Thanks for the PR, I'm not against that change, but the way it is done is not correct:

  • As with LSHIFT/RSHIFT or similar, we should not abstract away what exact key have been pressed at backend level.

  • If we are going for that change:

    • The backend should call a new method called ceramic.App.app.textInput.kpEnter() so that we can decide what to do with it at higher level and we don't lose any information on the way

    • All backends should be supported, not only clay backend. The call to kpEnter() should also be added in unity backend

@jeremyfa jeremyfa force-pushed the master branch 12 times, most recently from 43f9ee1 to aeb18ef Compare May 19, 2025 12:10
@jeremyfa jeremyfa merged commit ec212aa into ceramic-engine:master May 22, 2025
@jeremyfa
Copy link
Member

Changes look good now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants