Manual "self upgrade"#91
Merged
cert-manager-prow[bot] merged 2 commits intocert-manager:mainfrom Aug 13, 2025
Merged
Conversation
cert-manager-prow
bot
added
dco-signoff: yes
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
erikgb
force-pushed
the
manual-self-upgrade
branch
from
e7caf00 to
9151d95
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
| } | ||
|
|
||
| func New(endpoint string, log logr.Logger, opts Options) (*Driver, error) { | ||
| func New(ctx context.Context, endpoint string, log logr.Logger, opts Options) (*Driver, error) { |
Member
There was a problem hiding this comment.
Breaking change. I've added this to the release notes.
Member
There was a problem hiding this comment.
And with hindsight, we could have passed a contextual logger here and removed the log parameter.
This was referenced Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a manual alternative to #90, as the self-upgrade workflow seems to always be failing now. Probably because of workflow updates, but this works in other projects..... https://github.com/cert-manager/csi-lib/actions/workflows/make-self-upgrade.yaml
The PR also includes a separate commit to fix new noctx linter violations.