Also copy c-m chart to non-v-prefixed tag#246
Also copy c-m chart to non-v-prefixed tag#246SgtCoDFish wants to merge 1 commit intocert-manager:masterfrom
Conversation
cert-manager-prow
bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
size/S
There was a problem hiding this comment.
Pull request overview
Adds a second OCI tag for the cert-manager Helm chart without the leading v (e.g., 1.14.0 in addition to v1.14.0) to make helm upgrade flows easier when version resolution expects non-v semver tags.
Changes:
- Derive a non-
vversion string fromRELEASE_VERSIONand copy the chart OCI artifact to that tag. - Sign the newly created non-
vtag with cosign (matching the existing signing flow for thevtag).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SgtCoDFish
force-pushed
the
copy-chart
branch
3 times, most recently
from
dc2f59d to
c759aaf
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hack/push_and_sign_chart.sh
Outdated
| echo "$RELEASE_VERSION is not v-prefixed, skipping copy to non-v-prefixed version" | ||
| exit 0 |
There was a problem hiding this comment.
The indentation here uses a tab character, which is inconsistent with the rest of this script. The script uses 2-space indentation throughout (see lines 39-40, 44-45, 76-77). Please change the tab to 2 spaces to maintain consistency.
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
SgtCoDFish
force-pushed
the
copy-chart
branch
from
c759aaf to
fec5ae7
Compare
1 participant
This helps with
helm upgradeuse!