Skip to content

post-1.20-release: remove testing for release-1.18#1164

Open
maelvls wants to merge 1 commit intomasterfrom
cleanup-after-1.20-release
Open

post-1.20-release: remove testing for release-1.18#1164
maelvls wants to merge 1 commit intomasterfrom
cleanup-after-1.20-release

Conversation

@maelvls
Copy link
Copy Markdown
Member

@maelvls maelvls commented Mar 27, 2026 •
edited
Loading

This is one of the two last steps of the release process:

  • (final release only) Create a PR on cert-manager/testing, removing any unsupported release versions from prow config.

  • (final release only) In cert-manager/testing check milestone_applier config so that newly raised PRs on master are applied to a new milestone for the next release.

    Also check required status checks for the release branch and testgrid dashboard configuration.

    If the milestone for the next release doesn't exist, create it first. If you consider the milestone for the version you just released to be complete, close it.

I've also removed Kubernetes 1.31 and 1.32 as they are no longer supported upstream (see https://kubernetes.io/releases/).

I'll have to update the Supported Releases page too, as it mentions 1.31 and 1.32. IMO we should remove the "Supported" column and only keep the "Tested versions" in the Supported Releases page as I don't know on what basis we can say that 1.31 and 1.32 are supported since we don't test them anymore...

Parent issue: cert-manager/cert-manager#8656

Copilot AI review requested due to automatic review settings March 27, 2026 09:42
@cert-manager-prow cert-manager-prow bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Mar 27, 2026
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign erikgb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2026
@maelvls maelvls force-pushed the cleanup-after-1.20-release branch from 2f2ca28 to b6fed07 Compare March 27, 2026 09:43
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 27, 2026
Copilot AI reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates cert-manager’s Prow job generation/config to drop testing for older cert-manager/Kubernetes versions as part of the post-v1.20 release process, including removing the release-1.18 branch from prowgen and updating generated jobs to stop targeting Kubernetes 1.31/1.32.

Changes:

  • Remove the release-1.18 BranchSpec from prowgen branch definitions.
  • Update generated presubmit/periodic job matrices for master, release-1.19, and release-1.20 to use Kubernetes 1.33–1.35 (and adjust crons accordingly).
  • Regenerate job YAMLs reflecting the updated Kubernetes version targets.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.

File Description
config/prowgen/prowspecs/specs.go Removes release-1.18 branch spec and updates Kubernetes version matrices for remaining branches.
config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml Updates master presubmit/periodic jobs to Kubernetes 1.33–1.35 and adjusts schedules.
config/jobs/cert-manager/cert-manager/release-1.19/cert-manager-release-1.19.yaml Updates release-1.19 presubmit/periodic jobs to Kubernetes 1.33–1.35 and adjusts schedules.
config/jobs/cert-manager/cert-manager/release-1.20/cert-manager-release-1.20.yaml Updates release-1.20 presubmit/periodic jobs to Kubernetes 1.33–1.35 and adjusts schedules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

config/prowgen/prowspecs/specs.go Outdated
Comment on lines 51 to 53
primaryKubernetesVersion: "1.34",
otherKubernetesVersions: []string{"1.31", "1.32", "1.33", "1.35"},
otherKubernetesVersions: []string{"1.33", "1.34", "1.35"},

Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherKubernetesVersions includes the primary version (1.34). This causes prowgen to generate duplicate job names (one optional + one required) for v1.34 and also duplicate periodics. Remove the primary version from otherKubernetesVersions so it only contains secondary versions.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

@maelvls maelvls Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks! I'll fix this.

@maelvls maelvls force-pushed the cleanup-after-1.20-release branch from b6fed07 to 9403b9c Compare March 27, 2026 09:49
@cert-manager-prow cert-manager-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2026
@maelvls maelvls mentioned this pull request Mar 27, 2026
Open
@maelvls
post-1.20-release: remove testing for release-1.18
f9e1160 
Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls maelvls force-pushed the cleanup-after-1.20-release branch from 9403b9c to f9e1160 Compare March 27, 2026 09:58
erikgb
erikgb reviewed Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maelvls, you can self-approve. Just in case you want to bump the cert-manager version.

prow/cert-manager_install.sh
--namespace cert-manager \
--create-namespace \
--version v1.18.2 \
--version v1.20.0 \
Copy link
Copy Markdown
Member

@erikgb erikgb Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--version v1.20.0 \
--version v1.20.1 \

Not that it matters much, but 1.20.1 is currently our latest release.

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikgb erikgb erikgb left review comments

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maelvls @erikgb