Explain that cmctl x uninstall is now safe by default#1446
Merged
jetstack-bot merged 3 commits intocert-manager:masterfrom Mar 15, 2024
Merged
Explain that cmctl x uninstall is now safe by default#1446jetstack-bot merged 3 commits intocert-manager:masterfrom
jetstack-bot merged 3 commits intocert-manager:masterfrom
Conversation
jetstack-bot
added
dco-signoff: yes
inteon
force-pushed
the
document_cmctl_safe_uninstall
branch
from
203d31d to
1a6f7e0
Compare
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
inteon
force-pushed
the
document_cmctl_safe_uninstall
branch
from
1a6f7e0 to
97ff7f2
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
document_cmctl_safe_uninstall
branch
from
97ff7f2 to
8c893a5
Compare
inteon
commented
Mar 13, 2024
|
|
||
| cmctl x uninstall --dry-run | ||
|
|
||
| cmctl x uninstall --no-hooks |
Member
Author
There was a problem hiding this comment.
unrelated change: this flag is no longer supported since v2.0.0
wallrj
previously requested changes
Mar 15, 2024
jetstack-bot
added
do-not-merge/hold
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Member
Author
|
/approve |
jetstack-bot
added
the
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/unhold |
jetstack-bot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the documentation for the feature that was added in cert-manager/cmctl#13.