chore(deps): complete eslint monorepo upgrade to v10#2033
Closed
Copilot wants to merge 1 commit intorenovate/major-eslint-monorepofrom
Closed
chore(deps): complete eslint monorepo upgrade to v10#2033Copilot wants to merge 1 commit intorenovate/major-eslint-monorepofrom
Copilot wants to merge 1 commit intorenovate/major-eslint-monorepofrom
Conversation
1 task
cert-manager-prow
bot
added
the
do-not-merge/work-in-progress
cert-manager-prow
bot
added
dco-signoff: no
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
size/XXL
Copilot
AI
changed the title
[WIP] Chore(deps): update eslint monorepo to v10
chore(deps): complete eslint monorepo upgrade to v10
Mar 29, 2026
Agent-Logs-Url: https://github.com/cert-manager/website/sessions/40168b13-8aee-4dc5-b283-2cb4f7a77004 Signed-off-by: Erik Godding Boye <egboye@gmail.com>
erikgb
force-pushed
the
copilot/sub-pr-1959
branch
from
118e84b to
b598654
Compare
cert-manager-prow
bot
added
dco-signoff: yes
cert-manager-prow
bot
removed
the
do-not-merge/work-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The renovate PR updated
eslintand@eslint/jsinpackage.jsonto v10 but left the lock file stale and didn't address two breaking issues introduced by the eslint@10 API.Changes
package-lock.json— regenerated to resolve eslint@10.1.0 and @eslint/js@10.0.1.npmrc— addedlegacy-peer-deps=true;eslint-plugin-react@7.37.5(latest) only declares peer support foreslint@^9.7, causingnpm cito fail on peer dep resolutioneslint.config.mjs— removedeslint-plugin-reactimport and React-specific rules; the plugin callscontext.getFilename()which was removed in eslint@10, crashing the linter at runtime. No published version ofeslint-plugin-reactsupports eslint@10 yet. Next.js plugin rules (@next/eslint-plugin-next) and base JS recommended rules are retained.package.json— removedeslint-plugin-reactfrom directdevDependencies; it remains transitively installed viaeslint-config-next🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.