Upgrade eslint to v10, migrate from eslint-plugin-react to @eslint-react/eslint-plugin#2045
Conversation
…act/eslint-plugin Signed-off-by: Erik Godding Boye <egboye@gmail.com>
cert-manager-prow
bot
added
do-not-merge/work-in-progress
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
erikgb
changed the title
cert-manager-prow
bot
removed
the
do-not-merge/work-in-progress
|
/cc @inteon |
There was a problem hiding this comment.
Pull request overview
Updates the website’s linting toolchain to support ESLint v10 by migrating off eslint-plugin-react (which blocks ESLint v10) and adopting @eslint-react/eslint-plugin, with corresponding flat-config updates.
Changes:
- Bump
eslint/@eslint/jsto v10 and add@eslint-react/eslint-plugin; removeeslint-plugin-reactandeslint-config-next. - Update
eslint.config.mjsto use@eslint-react’s recommended flat config alongside Next.js rules. - Regenerate
package-lock.jsonto reflect the updated dependency graph.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates devDependencies to ESLint v10 and switches React lint plugin package. |
| eslint.config.mjs | Migrates flat ESLint config from eslint-plugin-react to @eslint-react recommended config. |
| package-lock.json | Regenerates lockfile to align with updated ESLint/react lint dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "devDependencies": { | ||
| "@eslint/js": "9.39.4", | ||
| "@eslint-react/eslint-plugin": "4.2.3", |
There was a problem hiding this comment.
@eslint-react/eslint-plugin@4.2.3 declares engines.node >=22.0.0 (and pulls in other @eslint-react/* packages with the same constraint). This conflicts with this repo’s current engines.node >=20.19.0 and can break installs for Node 20 users (or any CI with engine-strict). Either bump the repo’s Node engine to >=22 or choose a @eslint-react/eslint-plugin version that supports Node 20.19.
| "@eslint-react/eslint-plugin": "4.2.3", | |
| "@eslint-react/eslint-plugin": "3.0.0", |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
lgtm
This is a new PR fixing DCO based on the Copilot PR raised in #2044. The migration was inspired by the last comments on jsx-eslint/eslint-plugin-react#3977.
Closes #2044 #1959