feat: shortcut button component #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cesium-hydrogen-new ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
@JoaoCoelho2003 kiss |
joaodiaslobo
previously requested changes
Mar 12, 2025
github-project-automation
bot
moved this from Todo
to In Progress
in Hydrogen - Development
diogogmatos
approved these changes
Mar 13, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Hydrogen - Development
DevJoanaC
pushed a commit
that referenced
this pull request
Mar 23, 2025
* feat: shortcut button component implemented * fix: format * chore: improvements * fix: now the component opens the page in another window * chore: removed temporary code from the events page --------- Co-authored-by: Diogo Matos <me@diogogmatos.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#119
The shortcut button component is implemented and ready for review, not only did I implement the component but I also added to the events page a bunch of different buttons using said component so that it can be easier for the reviewer to check if everything is working as it should:
Here are the same buttons but on mobile:
As it was requested, when calling the component the text in the highlight can be specified and it is also flexible when it comes to the content inside the button (text, image, etc).