Skip to content

feat: custom selection colors #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
diogogmatos merged 4 commits into from
Apr 9, 2025
Merged

feat: custom selection colors #192

diogogmatos merged 4 commits into from
Apr 9, 2025

Conversation

@diogogmatos
Copy link
Member

@diogogmatos diogogmatos commented Mar 29, 2025 •
edited
Loading

Closes #156

@diogogmatos diogogmatos self-assigned this Mar 29, 2025
@diogogmatos diogogmatos mentioned this pull request Mar 29, 2025
Closed
@netlify
Copy link

netlify bot commented Mar 29, 2025 •
edited
Loading

✅ Deploy Preview for cesium-hydrogen-new ready!

Name Link
🔨 Latest commit b8b86ea
🔍 Latest deploy log https://app.netlify.com/sites/cesium-hydrogen-new/deploys/67f679b06ddf800008a584dc
😎 Deploy Preview https://deploy-preview-192--cesium-hydrogen-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@diogogmatos diogogmatos added the enhancement New feature or request label Mar 29, 2025
joaodiaslobo
joaodiaslobo previously requested changes Apr 7, 2025
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the full white in the home hero:

image

Can you change this, please? 🙇 Thanks!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Hydrogen - Development Apr 7, 2025
@diogogmatos
Copy link
Member Author

diogogmatos commented Apr 7, 2025 •
edited
Loading

Oop- that wasn't supposed to happen. This was a weird one, since we had a custom "blue" color in Tailwind but there is already a "blue" color defined by Tailwind itself, on /about/become-a-collaborator the hierarchy was getting messed up and the text would show selected as orange instead of blue.

To fix this I had to change the name of the color for our custom blue into something different, I thought "signature-blue" was okay.

As for the text not turning orange in the case you mentioned, I have no idea why "selection:text-primary" does not override the default text-white, so to fix it I just changed it to a bg-white with opacity, which I think also looks good.

Let me know what you think @joaodiaslobo 🙌🏼

@diogogmatos diogogmatos requested a review from joaodiaslobo April 7, 2025 23:56
joaodiaslobo
joaodiaslobo approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :shipit:

@diogogmatos diogogmatos merged commit 6477f04 into develop Apr 9, 2025
4 checks passed
@diogogmatos diogogmatos deleted the dm/selection-colors branch April 9, 2025 13:47
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hydrogen - Development Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaodiaslobo joaodiaslobo joaodiaslobo approved these changes

@nunom27 nunom27 Awaiting requested review from nunom27

Assignees

@diogogmatos diogogmatos

Labels

enhancement New feature or request

Projects

Hydrogen - Development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@diogogmatos @joaodiaslobo