New HttpClients are created-per request

[aspriddell]

HttpClients are designed to be reused, and as such shouldn't be disposed of:

https://github.com/abuZayed15/check-link/blob/d57972cb7c91e0cfcef709e62cb600e5112fb832/CheckLinkCLI2/CheckLinkCLI2/WebLinkChecker.cs#L67-L70 https://github.com/abuZayed15/check-link/blob/d57972cb7c91e0cfcef709e62cb600e5112fb832/CheckLinkCLI2/CheckLinkCLI2/WebLinkChecker.cs#L161-L164

I think it would be a good idea to create a static HttpClient and reuse it, without disposing of it.
You also might want to consider using something like DragonFruit.Common, which simplifies all of this into classes where the requests are generated and the client disposal/management are done for you. (should you want to use this I can explain how to use it)

Also worth noting you need to dispose of the HttpResponseMessages:
https://github.com/abuZayed15/check-link/blob/d57972cb7c91e0cfcef709e62cb600e5112fb832/CheckLinkCLI2/CheckLinkCLI2/WebLinkChecker.cs#L76 https://github.com/abuZayed15/check-link/blob/d57972cb7c91e0cfcef709e62cb600e5112fb832/CheckLinkCLI2/CheckLinkCLI2/WebLinkChecker.cs#L166

[ceterisp]

Sure. The way you implemented DragonFruit.Common and then use it on your other repos is interesting.

[aspriddell]

I'll look at cleaning up the wiki as there are a few new PRs in the works

[ceterisp]

Sure, take your time. We can do this when you're free. Thanks again for the suggestion!

[aspriddell]

I've finished writing most of the wiki, give it a read when you're free and let me know if there's anything that doesn't make sense.

It might be worth reading it all in the order it's displayed in the sidebar

[ceterisp]

Thank you! I will check it out and communicate with you accordingly