Skip to content
This repository was archived by the owner on Jul 10, 2020. It is now read-only.

Update atomic-component dep to v1.4#623

Merged
contolini merged 1 commit intocanaryfrom
update-atomic-component
Sep 21, 2017
Merged

Update atomic-component dep to v1.4#623
contolini merged 1 commit intocanaryfrom
update-atomic-component

Conversation

@contolini
Copy link
Member

Bumping atomic-component to the new pre-transpiled version.

Changes

  • capital-framework: [patch] Update atomic-component dependency in main package.json.
  • cf-expandables: [patch] Update atomic-component dependency to 1.4.0.
  • cf-tables: [patch] Update atomic-component dependency to 1.4.0.

Testing

Screenshots

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Testing checklist

Browsers

  • Chrome
  • Safari
  • FF
  • IE10
  • IE9
  • IE8
  • Opera
  • iOS
  • Android
  • Blackberry Bold

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@contolini contolini merged commit 25a8a60 into canary Sep 21, 2017
@jimmynotjim jimmynotjim deleted the update-atomic-component branch October 4, 2017 02:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant