fix: abort request when timeout occurs#1440
Merged
wendux merged 1 commit intocfug:developfrom Mar 29, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
developto avoid conflicts (via merge from master or rebase)This merge request fixes / refers to the following issues: ...
Pull Request Description
browser_adapterabort request when timeout occurs.https://github.com/flutterchina/dio/blob/6d04ec95d951bdecd19a2939d94de217d2d1ff7d/dio/lib/src/adapters/browser_adapter.dart#L78
https://github.com/flutterchina/dio/blob/6d04ec95d951bdecd19a2939d94de217d2d1ff7d/dio/lib/src/adapters/browser_adapter.dart#L102
https://github.com/flutterchina/dio/blob/6d04ec95d951bdecd19a2939d94de217d2d1ff7d/dio/lib/src/adapters/browser_adapter.dart#L128
io_adapterdetach socket whenreceiveTimeoutis occurs.https://github.com/flutterchina/dio/blob/6d04ec95d951bdecd19a2939d94de217d2d1ff7d/dio/lib/src/adapters/io_adapter.dart#L119
But
io_adapterdoes not abort the request whenconnectTimeoutandsendTimeoutare occurs. And we usesocket.destroy()instead ofsocket.close().https://api.dart.dev/stable/2.16.1/dart-io/Socket/close.html
https://api.dart.dev/stable/2.16.1/dart-io/Socket/destroy.html