Skip to content

Bump cronet_http version to ^1.0.0#2082

Merged
ueman merged 2 commits intocfug:mainfrom
amondnet:cronet_http_1.0.0
Dec 30, 2023
Merged

Bump cronet_http version to ^1.0.0#2082
ueman merged 2 commits intocfug:mainfrom
amondnet:cronet_http_1.0.0

Conversation

@amondnet
Copy link
Copy Markdown
Contributor

@amondnet amondnet commented Dec 29, 2023 •
edited
Loading

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

dart-lang/http#1087

@amondnet amondnet requested a review from a team as a code owner December 29, 2023 06:31
ueman
ueman reviewed Dec 29, 2023
View reviewed changes
Comment thread plugins/native_dio_adapter/pubspec.yaml Outdated
ueman
ueman reviewed Dec 30, 2023
View reviewed changes
Comment thread plugins/native_dio_adapter/CHANGELOG.md Outdated
ueman
ueman reviewed Dec 30, 2023
View reviewed changes
Comment thread plugins/native_dio_adapter/README.md

> Note: This uses the native http implementation on macOS, iOS and Android.
> Other platforms still use the Dart http stack.
> Please keep in mind that Android is still considered experimental.
Copy link
Copy Markdown
Contributor

@ueman ueman Dec 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ueman
Loosen dependency constraints
32f394e 
Signed-off-by: Jonas Uekötter <ueman@users.noreply.github.com>
ueman
ueman approved these changes Dec 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ueman ueman added this pull request to the merge queue Dec 30, 2023
Merged via the queue into cfug:main with commit 1524ae5 Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ueman ueman ueman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amondnet @ueman