Skip to content

Revert "Catch sync/async exceptions in interceptors' handlers"#2169

Merged
AlexV525 merged 3 commits intomainfrom
revert/2139
Mar 28, 2024
Merged

Revert "Catch sync/async exceptions in interceptors' handlers"#2169
AlexV525 merged 3 commits intomainfrom
revert/2139

Conversation

@AlexV525
Copy link
Copy Markdown
Member

Reverts #2139
Fixes #2167
Reopen #2138

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

Added tests were fake, so they remained effective after the revert.

@AlexV525 AlexV525 added p: dio Targeting `dio` package s: bug Something isn't working b: regression Worked before but not now 🚒 URGENT Needs to be resolved immediately labels Mar 28, 2024
@AlexV525 AlexV525 self-assigned this Mar 28, 2024
@AlexV525 AlexV525 requested a review from a team as a code owner March 28, 2024 03:23
@github-actions
Copy link
Copy Markdown
Contributor

Code Coverage Report

Package Base Coverage New Coverage Difference
dio 🟢 80.26% 🟢 81% 🟢 0.74%
Overall Coverage 🟢 80.26% 🟢 81% 🟢 0.74%

Minimum allowed coverage is 0%, this run produced 81%

@AlexV525 AlexV525 merged commit d256629 into main Mar 28, 2024
@AlexV525 AlexV525 deleted the revert/2139 branch March 28, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b: regression Worked before but not now p: dio Targeting `dio` package s: bug Something isn't working 🚒 URGENT Needs to be resolved immediately

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interceptor onError handling broken

1 participant