fix: parse single-string JSON response (#2509)#2510
Open
IKBASYSTEMS wants to merge 1 commit intocfug:mainfrom
Open
fix: parse single-string JSON response (#2509)#2510IKBASYSTEMS wants to merge 1 commit intocfug:mainfrom
IKBASYSTEMS wants to merge 1 commit intocfug:mainfrom
Conversation
AlexV525
requested changes
Apr 22, 2026
Member
AlexV525
left a comment
AlexV525
left a comment
There was a problem hiding this comment.
The issue is missing a specific repro path thus the fix is also invalid at this moment. We have multiple options and checks that guard JSON parses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2509.
ResponseType.jsonwith a single JSON string value (e.g."ok") was not parsed correctly.This updates parsing in
dio_mixinand adds regression tests inoptions_test.dart(with adapter support intest/mock/adapters.dart).Checklist:
✅ tests added
✅ branch up to date (you are)
✅ run tests first, then mark done