feat(health): add configurable retry logic for health checks#8
Merged
pamungkaski merged 1 commit intomainfrom Jan 23, 2026
Merged
feat(health): add configurable retry logic for health checks#8pamungkaski merged 1 commit intomainfrom
pamungkaski merged 1 commit intomainfrom
Conversation
Add health_check_max_failures config to prevent nodes from being marked unhealthy on transient failures. Nodes now require X consecutive failed health checks (default: 3) before being marked unhealthy, providing better resilience against temporary network issues and momentary lag spikes. Key changes: - Add health_check_max_failures to Global config (default: 3) - Add consecutive_failures tracking to ElNodeState and ClNodeState - Update calculate_el_health() and calculate_cl_health() to implement retry logic - Reset failure counter on successful health check - Update all test helpers and add comprehensive retry/recovery tests The retry logic prevents health status flapping while maintaining quick recovery when nodes become healthy again. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
merklefruit
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add health_check_max_failures config to prevent nodes from being marked unhealthy on transient failures. Nodes now require X consecutive failed health checks (default: 3) before being marked unhealthy, providing better resilience against temporary network issues and momentary lag spikes.
Key changes:
The retry logic prevents health status flapping while maintaining quick recovery when nodes become healthy again.