Revert instructions for configure-npm with pnpm#3301
Open
s-stumbo wants to merge 1 commit into
Open
Conversation
Signed-off-by: s-stumbo <sally.stumbo@chainguard.dev>
✅ Deploy Preview for ornate-narwhal-088216 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
angela-zhang
reviewed
May 6, 2026
| ```bash | ||
| export token=$(echo -n "${CHAINGUARD_JAVASCRIPT_IDENTITY_ID}:${CHAINGUARD_JAVASCRIPT_TOKEN}" | base64 -w 0) | ||
|
|
||
| pnpm config set registry https://libraries.cgr.dev/javascript/ --location=project |
Contributor
There was a problem hiding this comment.
it seems like /javascript-upstream/ is also needed for pnpm, but I'm checking with the engineering team to confirm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Check if this is a typo or other quick fix and ignore the rest :)
Type of change
Update to pnpm minimal example in Build configuration docs
What should this PR do?
Revert the instructions for updating your npmrc file
Why are we making this change?
Issue reported here: https://chainguard-dev.slack.com/archives/C09MK1VTHL6/p1778080178619079
What are the acceptance criteria?
Content should appear in the expected location
How should this PR be tested?
Review the deploy preview