Update Artifactory packages pull-through guide to use Docker build secrets#3304
Merged
Conversation
…crets Replace hardcoded Artifactory tokens in /etc/apk/repositories with Docker build secrets, preventing tokens from being stored in image layers or build history. Resolves internal#5839. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for ornate-narwhal-088216 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
s-stumbo
approved these changes
May 8, 2026
jasonbishay
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/etc/apk/repositorieswith Docker build secrets (--mount=type=secret), preventing tokens from being stored in image layers or appearing indocker historyRUNinstruction so credentials never persist in a layerdocker buildcommands to pass tokens via--secret id=...,env=...and non-sensitive config via--build-argcg-private) and public repo (cg-chainguard,cg-extras) DockerfilesFixes: chainguard-dev/internal#5839
Test plan
<<'EOF'heredoc syntax is accurate (single-quoted to prevent shell expansion)--secret id=...,env=...and--mount=type=secretsyntax is correct for current Docker Buildx🤖 Generated with Claude Code