chore: bump yara-x to 1.13.0; match upstream config; run Make targets consistently#1389
Draft
egibs wants to merge 1 commit intochainguard-dev:mainfrom
Draft
chore: bump yara-x to 1.13.0; match upstream config; run Make targets consistently#1389egibs wants to merge 1 commit intochainguard-dev:mainfrom
egibs wants to merge 1 commit intochainguard-dev:mainfrom
Conversation
… consistently Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
force-pushed
the
bump-yara-x-1.13.0
branch
from
b5f9432 to
03808e7
Compare
| - name: Unit tests | ||
| run: | | ||
| make test | ||
| go test -race ./pkg/... |
Member
There was a problem hiding this comment.
Probably a dumb question, but what's the reasoning behind dropping the use of the make target here and for the integration tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps yara-x to v1.13.0, the
go.modversion to 1.26.0 (intentional; this release has a ~30% CGO runtime improvement and Go1.26 is now GA), and finally configures all of the Make targets to correctly use flags required to pull in the yara-x C API correctly.Previously, we were only doing this for
make out/maland runningmake testormake golangci-lint-fixwould require that they be manually specified to function correctly.This PR also moves
make install-yara-xto use the static pattern used by both upstream and Wolfi and makes overall maintenance of the release version easier over time.