Skip to content

Separate out ignored packages in the report #157

@ericcornelissen

Description

@ericcornelissen

Currently, at least when using dirty-waters-action@v1.11.43, the report puts ignored packages in the "Other info" section together with e.g. the note that a package isn't hosted on GitHub (and it's implications). I would expect these two things to be separated, in particular I would expect a dedicated section for the ignored findings. I find it to be a bit confusing to have these two in the same table and it makes it a bit hard to tell why its there.

As an additional request, I'd also like to know which rule caused a particular result to be ignored.

Example

Current

The below is an extract of the relevant part of the report, currently.


...

Notes

Other info:
  • Source code repo is not hosted on GitHub: 4

    This could be due, for example, to the package being hosted on a different platform.

    This does not mean that the source code URL is invalid.

    However, for non-GitHub repositories, not all checks can currently be performed.

index package_name github_url parent
1 concat-map@0.0.1 Could not find repo from package registry ['brace-expansion@1.1.11']
2 file-entry-cache@8.0.0 Could not find repo from package registry []
3 micro-spelling-correcter@1.1.1 Could not find repo from package registry []
4 pp-test-kit@0.5.1 git+https://gitlab.com/ericcornelissen/pp-test-kit.git []

...


Suggested

The below is my suggested structure of the relevant part of the report. To clarify, under the "ignored" section I'm expecting the same structure as in the "Fine grained information" section, but instead with the ignored packages only.


...

Notes

Other info:
  • Source code repo is not hosted on GitHub: 4

    This could be due, for example, to the package being hosted on a different platform.

    This does not mean that the source code URL is invalid.

    However, for non-GitHub repositories, not all checks can currently be performed.

index package_name github_url parent
1 pp-test-kit@0.5.1 git+https://gitlab.com/ericcornelissen/pp-test-kit.git []
Ignored:
  • Source code links that could not be found(3)
index package_name github_url parent
1 concat-map@0.0.1 Could not find repo from package registry ['brace-expansion@1.1.11']
2 file-entry-cache@8.0.0 Could not find repo from package registry []
3 micro-spelling-correcter@1.1.1 Could not find repo from package registry []
  • List of packages with available source code repos but with inaccessible commit SHAs/tags(0)
  • Packages without code signature(0)
  • List packages with valid code signature(0)

...


Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions