Skip to content

Conversation

@cgruber
Copy link
Contributor

@cgruber cgruber commented Aug 15, 2025

No description provided.

@cgruber cgruber force-pushed the bump_pebble branch 2 times, most recently from 92a6df6 to 441061c Compare August 15, 2025 02:20
@cgruber cgruber marked this pull request as ready for review August 15, 2025 02:29
Copy link
Collaborator

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgruber Thanks! The CI fails because of go.mod issue. You might need to call go mod tidy I guess

@asdine
Copy link
Collaborator

asdine commented Aug 15, 2025

Ok I see the problem you need to call go mod tidy in ./cmd/chai.
Or just call make tidy and it should do it for you

@cgruber
Copy link
Contributor Author

cgruber commented Aug 15, 2025

Ah crap - I was wondering - i didn't notice it was a separate mod. On it.

@cgruber cgruber requested a review from asdine August 15, 2025 02:56
@cgruber
Copy link
Contributor Author

cgruber commented Aug 15, 2025

My bad. I didn't run the tests for /cmd locally.

@asdine
Copy link
Collaborator

asdine commented Aug 15, 2025

You can use make test

@cgruber
Copy link
Contributor Author

cgruber commented Aug 15, 2025

Yeah - sorry, our setup at work is a bit different, so I'm just figuring out the tricks in yours. Got them all passing locally now.

@cgruber
Copy link
Contributor Author

cgruber commented Aug 15, 2025

First PR blues.

@asdine
Copy link
Collaborator

asdine commented Aug 15, 2025

Haha no worries, plus there's no documentation on how to run them so one can only guess

@cgruber
Copy link
Contributor Author

cgruber commented Aug 15, 2025

Crazy good response time, though. Thanks so much. This unblocks me. I'm using this for a test-only implementation of something that front-ends a back-end database, so this lets me make really fast tests. I'm pumped.

@asdine
Copy link
Collaborator

asdine commented Aug 15, 2025

Keep in mind that the project is a WIP and it's taking a different direction than what's in the main README, so I would advise (perhaps a bit late) to not use it in production for now (unless you're fine with using only the in-memory version and some breaking changes in the future). cf dev branch

Copy link
Collaborator

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is green! Thanks @cgruber !

@asdine asdine merged commit 4fce4a7 into chaisql:main Aug 15, 2025
1 check passed
@asdine
Copy link
Collaborator

asdine commented Aug 15, 2025

I'll release a patch version in a bit

@cgruber
Copy link
Contributor Author

cgruber commented Aug 15, 2025

Awesome. Yeah - I'm only using it for a fake implementation used for unit testing, and only in-memory. If you take it in a different direction I hope you keep that use-case at least. I had this in Java/Kotlin (in-memory sql db) and it's just so handy to avoid long integration tests.

@asdine
Copy link
Collaborator

asdine commented Aug 15, 2025

Yeah the new direction is mostly for the SQL API (it will be Postgres compatible) and the on-disk file format. I'll keep the in-memory part, CI is a big use case for this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants