-
Notifications
You must be signed in to change notification settings - Fork 100
Bump pebble #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pebble #541
Conversation
92a6df6 to
441061c
Compare
asdine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cgruber Thanks! The CI fails because of go.mod issue. You might need to call go mod tidy I guess
|
Ok I see the problem you need to call |
|
Ah crap - I was wondering - i didn't notice it was a separate mod. On it. |
|
My bad. I didn't run the tests for /cmd locally. |
|
You can use |
|
Yeah - sorry, our setup at work is a bit different, so I'm just figuring out the tricks in yours. Got them all passing locally now. |
|
First PR blues. |
|
Haha no worries, plus there's no documentation on how to run them so one can only guess |
|
Crazy good response time, though. Thanks so much. This unblocks me. I'm using this for a test-only implementation of something that front-ends a back-end database, so this lets me make really fast tests. I'm pumped. |
|
Keep in mind that the project is a WIP and it's taking a different direction than what's in the |
asdine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build is green! Thanks @cgruber !
|
I'll release a patch version in a bit |
|
Awesome. Yeah - I'm only using it for a fake implementation used for unit testing, and only in-memory. If you take it in a different direction I hope you keep that use-case at least. I had this in Java/Kotlin (in-memory sql db) and it's just so handy to avoid long integration tests. |
|
Yeah the new direction is mostly for the SQL API (it will be Postgres compatible) and the on-disk file format. I'll keep the in-memory part, CI is a big use case for this library. |
No description provided.